We use Code Analysis within a build server with the firm restriction that we cannot commit code if a Code Analysis rule breaks. CA1822 is enabled and therefore we have many, many static functions. Now we want to force unit tests with mocking and dependency injection. But with our many static functions it is not easy to mock some static function. Especially when a static function calls a static function. I'm thinking about disabling CA1822 to reduce the static functions because I'm aksing myself: Is CA1822 obsolete for development with a mocking fw and code injection? I read in many other questions, that performance is not the matter. So what for making a function static? In my opinion CA1822 lead to a bad design. Am I wrong?
Leads CA1822 to a bad design for modern development when it comes to unit testing?
505 Views Asked by Jeremy Benks At
1
There are 1 best solutions below
Related Questions in UNIT-TESTING
- How to write tests for classes with inheritance
- PHPunit call magic methods
- Convert IEnumerable to IObservable with variable Period
- How to a run specific code before & after each unit test in Python
- Unit testing a class A that derives from an abstract class B
- Is there another way to unit test business logic in mvc
- Some of my tests show prepended with junit.framework
- Selenium Driver Service not found exception
- Can not convert from Class<PowerMockRunner> to Class<? extends Runner>
- AngularJS Unit Testing - multiple mocks and providers
- How to use Sinon.js FakeXMLHttpRequest with superagent?
- Get Mock with AutoMock.Create<>()
- Mock service that takes unitOfWork in constructor
- Cleanest method for creating a pytest test fixture that takes in dynamic text data
- g++ 5.1.0 not building project, clang shows unknown error
Related Questions in MOCKING
- PHPunit call magic methods
- AngularJS Unit Testing - multiple mocks and providers
- How to use Sinon.js FakeXMLHttpRequest with superagent?
- Automatically wrap C/C++ function at compile-time with annotation
- How to mock specific RequireJs dependencies while unit testing
- Create mock based on existed real instance
- Overriding function with Sinon.mock?
- Spring MockRestServiceServer handling multiple requests to the same URI (auto-discovery)
- Sling Mock is not allowing to get ResourceResolverFactory
- Swift Mocking Class
- How can I mock methods of @InjectMocks class?
- Can I inject primitive variable into mocked class using annotation?
- How to capture field value when a method of a class is called in Python?
- Unit testing a fluent interface with Mockito
- Mocked repository does not trigger as expected
Related Questions in CODE-ANALYSIS
- Unknown code analysis error
- Detect if source is CSS/HTML/JavaScript
- Should nDepend's output folder be added to source control?
- Visual Studio's Rule Set Editor does not open
- Why do I get warning CA2229 (Implement serialization constructors) when inheriting from standard type
- Gradle: Setting PMD Arguments minimumPriority and shortFilenames
- nested using() and code rule CA2202
- How can i create a (design time only) nuget package that doesn't add an assembly reference when installed?
- Why is /optimize in a C# project generating more Code Analysis warnings than without this enabled?
- Code Analysis detected errors. No code analysis issues were detected
- WPF code analyze : CA2202 Do not dispose objects multiple timesObject
- WPF code analyze : CA1001 Types that own disposable fields should be disposable
- How to get better results from LLVM's MemoryDependenceAnalysis pass?
- Assembly name referred in project but same version not available
- Object 'iCrypt' can be disposed more than once
Related Questions in CODE-INJECTION
- Allow extension of class by injection of user-made subclass, while preserving accessibility
- C++ Injection Code
- Java EE using Datasource without lookup method
- Java polymorphism through injection at runtime
- Is FILTER_VALIDATE_EMAIL sufficient to stop shell injection?
- Protecting against user injection, running imagemagik from through command line
- How to inject a logging statement before every catch block in java
- Worried about html/script injection in angular app
- IHTMLDOMNode::appendChid() won't always work as expected
- Angular - function in dependency or dependency in function params?
- Android runtime code injection / method hooking with Java Reflection
- How can I inject or dynamically load an c function into another c program
- Access document object in my contentScriptInjection in js
- Command Injection DVWA Hard Difficulty
- auto js injected in js files [ default/base.js ] using Moblink 3G
Related Questions in TESTDRIVENDESIGN
- Java program to prove Test Driven Development
- TDD and MVC Crossroads. What ORM integrates nicely?
- Leads CA1822 to a bad design for modern development when it comes to unit testing?
- Where to start with test driven development?
- How can I test exceptions using Test Driven Design concept in eclipse
- Unit testing vs TDD(test driven dev) What is the difference?
- Why extract an interface when we can DI a delegate to make it testable?
- Some confusion about test driven development
- Unit test contains instances of other classes not only mocks
- TDD principle, how to make the test fail
- Repository pattern for database that allows CRUD operations through Interops
- Using Test-Driven in DDD (Domain layer)
- TDD multi threaded applications
- TDD CRUD based scenario
- TDD - beginner problems and stumbling blocks
Trending Questions
- UIImageView Frame Doesn't Reflect Constraints
- Is it possible to use adb commands to click on a view by finding its ID?
- How to create a new web character symbol recognizable by html/javascript?
- Why isn't my CSS3 animation smooth in Google Chrome (but very smooth on other browsers)?
- Heap Gives Page Fault
- Connect ffmpeg to Visual Studio 2008
- Both Object- and ValueAnimator jumps when Duration is set above API LvL 24
- How to avoid default initialization of objects in std::vector?
- second argument of the command line arguments in a format other than char** argv or char* argv[]
- How to improve efficiency of algorithm which generates next lexicographic permutation?
- Navigating to the another actvity app getting crash in android
- How to read the particular message format in android and store in sqlite database?
- Resetting inventory status after order is cancelled
- Efficiently compute powers of X in SSE/AVX
- Insert into an external database using ajax and php : POST 500 (Internal Server Error)
Popular Questions
- How do I undo the most recent local commits in Git?
- How can I remove a specific item from an array in JavaScript?
- How do I delete a Git branch locally and remotely?
- Find all files containing a specific text (string) on Linux?
- How do I revert a Git repository to a previous commit?
- How do I create an HTML button that acts like a link?
- How do I check out a remote Git branch?
- How do I force "git pull" to overwrite local files?
- How do I list all files of a directory?
- How to check whether a string contains a substring in JavaScript?
- How do I redirect to another webpage?
- How can I iterate over rows in a Pandas DataFrame?
- How do I convert a String to an int in Java?
- Does Python have a string 'contains' substring method?
- How do I check if a string contains a specific word?
CA1801 is the ReviewUnusedParameters rule. CA1822 is MarkMembersAsStatic, which is the one that I'm guessing is actually causing problems for you.
The good news is that neither of these rules fires for an implementation of an interface method, so you should have no problems with either rule if you start decoupling via interfaces in order to enable inversion of control and mock substitution for unit testing.