Not able to add new group permission in android

Question

I'm trying to add a new group permission in Android but it is not taking effect in my application (new CTS test). Below are the changes :

test@test-ubuntu:~/android_aosp/system/core$ git diff
diff --git a/include/private/android_filesystem_config.h b/include/private/android_filesystem_config.h
index d2193b7..7725126 100644
--- a/include/private/android_filesystem_config.h
+++ b/include/private/android_filesystem_config.h
@@ -77,6 +77,7 @@
#define AID_SDCARD_ALL    1035  /* access all users external storage */
#define AID_LOGD          1036  /* log daemon */
#define AID_SHARED_RELRO  1037  /* creator of shared GNU RELRO files */
+#define AID_XYZ           1038  /* files which XYZ needs to access */

#define AID_SHELL         2000  /* adb and debug shell user */
#define AID_CACHE         2001  /* cache access */
@@ -189,6 +190,7 @@ static const struct android_id_info android_ids[] = {
     { "sdcard_all",    AID_SDCARD_ALL, },
     { "logd",          AID_LOGD, },
     { "shared_relro",  AID_SHARED_RELRO, },
+    { "xyz",           AID_XYZ, },

     { "shell",         AID_SHELL, },
     { "cache",         AID_CACHE, },
test@test-ubuntu:~/android_aosp/system/core$
test@test-ubuntu:~/android_aosp/system/core$ cd ../../frameworks/base/
test@test-ubuntu:~/android_aosp/frameworks/base$
test@test-ubuntu:~/android_aosp/frameworks/base$
test@test-ubuntu:~/android_aosp/frameworks/base$ git diff
diff --git a/data/etc/platform.xml b/data/etc/platform.xml
index d3d7559..2e5d8c24 100644
--- a/data/etc/platform.xml
+++ b/data/etc/platform.xml
@@ -109,6 +109,10 @@
         <group gid="media" />
     </permission>

+    <permission name="android.permission.XYZ" >
+        <group gid="xyz" />
+    </permission>
+
     <!-- ================================================================== -->
     <!-- ================================================================== -->
     <!-- ================================================================== -->
test@test-ubuntu:~/android_aosp/frameworks/base$
test@test-ubuntu:~/android_aosp/frameworks/base$ cd ../../cts/tests/tests/newCtsTest/
test@test-ubuntu:~/android_aosp/cts/tests/tests/newCtsTest$
test@test-ubuntu:~/android_aosp/cts/tests/tests/newCtsTest$ git diff .
diff --git a/tests/tests/newCtsTest/AndroidManifest.xml b/tests/tests/newCtsTest/AndroidManifest.xml
index 52a0332..9dc3b1b 100755
--- a/tests/tests/newCtsTest/AndroidManifest.xml
+++ b/tests/tests/newCtsTest/AndroidManifest.xml
@@ -19,6 +19,8 @@
     package="android.newCtsTest.cts">

     <uses-permission android:name="android.permission.DISABLE_KEYGUARD" />
+    <uses-permission android:name="android.permission.XYZ" />
+
     <application>
         <uses-library android:name="android.test.runner" />
         <activity android:name="android.newCtsTest.SampleDeviceActivity" >
test@test-ubuntu:~/android_aosp/cts/tests/tests/newCtsTest$

Following is the file that I'm trying to write to from the application but it is not working :

root@board:/ # ls -l /sys/class/leds/led1/brightness
-rw-rw-r-- system   xyz          4096 2018-03-29 10:49 brightness
root@board:/ #

Note the permission for above file is 664. If I change it to 666 it works so the code itself doesn't have any issues, but somehow the group permission isn't applied to the application

Answer 1

I was able to solve the problem. Additional change has to be made in frameworks/base/core/res/AndroidManifest.xml :

test@test-ubuntu:~/android_aosp/frameworks/base$ git diff core/res/AndroidManifest.xml
diff --git a/core/res/AndroidManifest.xml b/core/res/AndroidManifest.xml
index 4b1c534..a4ba0b5 100644
--- a/core/res/AndroidManifest.xml
+++ b/core/res/AndroidManifest.xml
@@ -1054,6 +1054,12 @@
     <permission android:name="android.permission.BLUETOOTH_STACK"
         android:protectionLevel="signature" />

+    <!-- Allows applications to access files in xyz group.
+         <p>Protection level: normal
+    -->
+    <permission android:name="android.permission.XYZ"
+        android:protectionLevel="normal" />
+
     <!-- Allows applications to perform I/O operations over NFC.
          <p>Protection level: normal
     -->

After that need to execute make update-api and then build the full Android again